[system] Fix maxWidth incorrectly resolving breakpoints with non-pixel units #38633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-38633--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
force-pushed
the
fix/system-max-width
branch
from
cbb04ca
to
d5a68ba
Compare
mj12albert
force-pushed
the
fix/system-max-width
branch
from
d21f47e
to
efd64ba
Compare
mj12albert
requested review from
siriwatknp,
mnajdova and
brijeshb42
and removed request for
mnajdova
brijeshb42
reviewed
Aug 31, 2023
| }; | ||
| } | ||
|
|
||
| if (props.theme?.breakpoints?.unit !== 'px') { |
There was a problem hiding this comment.
Nit: Do we need to check if it's not px? Why not just append the unit?
There was a problem hiding this comment.
@brijeshb42 I just didn't want to change the existing behavior for pixels - i.e. returning maxWidth: 100 instead of maxWidth: '100px' 😬
brijeshb42
approved these changes
Sep 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
anon-phantom
pushed a commit
to anon-phantom/material-ui
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38594
Here's a sandbox showing the fix: https://codesandbox.io/s/https-github-com-mui-material-ui-pull-38633-6ry8rx?file=/src/App.tsx